Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Gain control for Vitals Monitor #5749

Closed
wants to merge 3 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 22, 2023

WHAT

🤖 Generated by Copilot at f398433

This pull request adds a feature to override waveform gains for the HL7Monitor component, improves the UI and functionality of the monitor configuration form, and fixes several bugs related to the respiration waveform and value in the HL7DeviceClient, HL7PatientVitalsMonitor, HL7VitalsRenderer, and useHL7VitalsMonitor modules.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f398433

  • Add a checkbox field and a card for overriding the waveform gains in the monitor configuration form (link, link, link, link, link, link, link, link, link)
  • Pass the gains values to the HL7PatientVitalsMonitor component and the useHL7VitalsMonitor hook to apply them to the waveform rendering (link, link, link, link, link, link, link, link, link)
  • Change the event name and the state variable for the respiration waveform and vitals from spo2 to resp to match the actual data from the monitor device (link, link, link, link, link, link, link, link, link, link)
  • Modify the layout and style of the connection card and the bed card in the monitor configuration form to make them more consistent and add save or update buttons to the top right corners (link, link, link, link)
  • Add the step prop to the TextFormField component to allow passing a custom step value for the input element of type number (link, link)

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 6:29pm

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9f30ce4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649b29c9718a410008d345b8
😎 Deploy Preview https://deploy-preview-5749--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 22, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale merge conflict pull requests with merge conflict labels Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the stale label Jul 6, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 14, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jul 22, 2023
@rithviknishad rithviknishad reopened this Jul 24, 2023
@github-actions github-actions bot removed the stale label Jul 25, 2023
@rithviknishad rithviknishad deleted the vitals-gain branch July 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable Timescale for Vitals Waveform
2 participants